4090 maintenance schema changes move notifications to event level#4153
Conversation
…anged services so that they check event instead of eventtype for sendslacknotifs
…teEvent service calls
…y anymore (it directly checks event for sendSlackNotifs)
… the correct places
cielbellerose
left a comment
cielbellerose
left a comment
There was a problem hiding this comment.
this looks awesome! only one small schema note. also make sure you are merging into the feature/event-notifications branch so we can merge BE and FE at the same time when the time comes
|
|
||
| */ | ||
| -- AlterTable | ||
| ALTER TABLE "Event" ADD COLUMN "sendSlackNotifications" BOOLEAN NOT NULL; |
There was a problem hiding this comment.
we should default this to false so it works with the existing events, also we don't need to include the above comment
wavehassman
left a comment
wavehassman
left a comment
There was a problem hiding this comment.
With the current migration, all events already made under an event type that has sendSlackNotifications set will no longer receive them since we're defaulting false. I think we should default false, but we should have the migration go through every event that is correlated to an event type in the organization where sendSlackNotification is true and make the new field in event true
wavehassman
merged commit 76a6055
into
feature/event-notifications
wavehassman
deleted the
4090-maintenance---schema-changes-move-notifications-to-event-level
branch
3 participants
Changes
Moved sendSlackNotifications from Event_Type to Event for routes, controllers, services, transformers, and in prisma and shared types. Created schema migration. Updated tests to match the new location of sendSlackNotifications, and tests (for backend) pass.
Screenshots
Create event route works
Edit event route works
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #4090